[msan][NFCI] Add tests for Arm NEON floating-point min/max (vector) #125729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently handled (suboptimally) by handleUnknownInstruction: - llvm.aarch64.neon.fmaxv (Floating-point Maximum (vector)) - llvm.aarch64.neon.fminv - llvm.aarch64.neon.fmaxnmv (Floating-point Maximum Number across Vector) - llvm.aarch64.neon.fminnmv Forked from llvm/test/CodeGen/AArch64/arm64-fminv.ll
thurstond
changed the title
fmayer
approved these changes
Feb 4, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/15241 Here is the relevant piece of the build log for the reference |
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Feb 4, 2025
Apply handleVectorReduceIntrinsic() to Intrinsic::aarch64_neon_f{min,max}(mn)?v. Previously, these were unknown intrinsics handled suboptimally by visitInstruction.
Updates the tests from llvm#125729.
thurstond
added a commit
that referenced
this pull request
Feb 6, 2025
Apply handleVectorReduceIntrinsic() to Intrinsic::aarch64_neon_f{min,max}(mn)?v. Previously, these intrinsics were handled correctly (by maybeHandleSimpleNomemIntrinsic) if each parameter's type was the same as the return type; otherwise, they were handled suboptimally by visitInstruction().
Updates the tests from #125729.
github-actions bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 6, 2025
…25778)
Apply handleVectorReduceIntrinsic() to Intrinsic::aarch64_neon_f{min,max}(mn)?v. Previously, these intrinsics were handled correctly (by maybeHandleSimpleNomemIntrinsic) if each parameter's type was the same as the return type; otherwise, they were handled suboptimally by visitInstruction().
Updates the tests from llvm/llvm-project#125729.
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
…lvm#125729) Currently handled (suboptimally) by handleUnknownInstruction: - llvm.aarch64.neon.fmaxv (Floating-point Maximum (vector)) - llvm.aarch64.neon.fminv - llvm.aarch64.neon.fmaxnmv (Floating-point Maximum Number across Vector) - llvm.aarch64.neon.fminnmv (not to be mistaken with llvm.aarch64.neon.f{max,min}, which are correctly handled by `maybeHandleSimpleNomemIntrinsic`) Forked from llvm/test/CodeGen/AArch64/arm64-fminv.ll
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
Apply handleVectorReduceIntrinsic() to Intrinsic::aarch64_neon_f{min,max}(mn)?v. Previously, these intrinsics were handled correctly (by maybeHandleSimpleNomemIntrinsic) if each parameter's type was the same as the return type; otherwise, they were handled suboptimally by visitInstruction().
Updates the tests from llvm#125729.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently handled (suboptimally) by handleUnknownInstruction:
(not to be mistaken with llvm.aarch64.neon.f{max,min}, which are correctly handled by
maybeHandleSimpleNomemIntrinsic)Forked from llvm/test/CodeGen/AArch64/arm64-fminv.ll